Skip to content

test: fix rhel updater check to deal with DeltaParse #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: fix rhel updater check to deal with DeltaParse #1611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89a4178
test: fix rhel updater check to deal with DeltaParse
crozzy Aug 28, 2025
910143d
chore: increase update-check test timeout
crozzy Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/updater-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ jobs:
with:
check-latest: true
go-version-file: ./go.mod
- run: go test ./test/periodic -enable
- run: go test -timeout=20m ./test/periodic -enable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed? It takes over 10 minutes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/quay/claircore/actions/runs/17303309277/job/49119753908 yeah :(

8 changes: 7 additions & 1 deletion test/periodic/updater_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"testing"
"time"

"github.com/quay/claircore"
"github.com/quay/zlog"

"github.com/quay/claircore/alpine"
Expand Down Expand Up @@ -164,6 +165,7 @@ func runUpdaterSet(ctx context.Context, t *testing.T, set driver.UpdaterSet) {
func runUpdater(ctx context.Context, t *testing.T, u driver.Updater) {
var rc io.ReadCloser
var nfp driver.Fingerprint
var vs []*claircore.Vulnerability
var err error
// Debounce any network hiccups.
for i := 0; i < 5; i++ {
Expand All @@ -187,7 +189,11 @@ func runUpdater(ctx context.Context, t *testing.T, u driver.Updater) {
}
}()

vs, err := u.Parse(ctx, rc)
if du, ok := u.(driver.DeltaUpdater); ok {
vs, _, err = du.DeltaParse(ctx, rc)
} else {
vs, err = u.Parse(ctx, rc)
}
if err != nil {
t.Error(err)
}
Expand Down
Loading