test: fix rhel updater check to deal with DeltaParse #1611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VEX updater exposes a DeltaParse() method that does all the work but the test just called Parse() for all updaters. This change checks if the DeltaParse() method is implemented and uses it, otherwise it uses Parse(). Signed-off-by: crozzy <joseph.crosland@gmail.com>
Now we are processing all the VEX files during the updater-check we need to increase from the 10m default. Signed-off-by: crozzy <joseph.crosland@gmail.com>
crozzy
force-pushed
the
fix-updater-check-ci
branch
from
ca47688 to
910143d
Compare
hdonnay
approved these changes
Sep 10, 2025
| check-latest: true | ||
| go-version-file: ./go.mod | ||
| - run: go test ./test/periodic -enable | ||
| - run: go test -timeout=20m ./test/periodic -enable |
There was a problem hiding this comment.
Is this really needed? It takes over 10 minutes?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VEX updater exposes a DeltaParse() method that does all the work but the test just called Parse() for all updaters. This change checks if the DeltaParse() method is implemented and uses it, otherwise it uses Parse().