Skip to content

Add inclusion fee for scheduled transactions #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add inclusion fee for scheduled transactions #548

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d63d66
add inclusion fee
devbugging Oct 15, 2025
f734ee0
update inclusion fee
devbugging Oct 15, 2025
70bd35f
Merge branch 'master' into gregor/inclusion-fee
devbugging Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion contracts/FlowTransactionScheduler.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,10 @@ access(all) contract FlowTransactionScheduler {
// Calculate the FLOW required to pay for storage of the transaction data
let storageFee = FlowStorageFees.storageCapacityToFlow(dataSizeMB)

return scaledExecutionFee + storageFee
// Add inclusion Flow fee for scheduled transactions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be better to just include in the FlowFees.computeFees call in calculateFees(). We can just use a higher inclusion effort there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but that wouldn't really be a base fee since it would depend on the priority. This felt to me more natural to think, like X is always minimum what you have to pay (no matter priority). But I'm open to change if you feel strongly against. How do you feel about the amount btw?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I just don't understand the purpose of this. Because the minimum execution effort is 100, there is always a minimum fee, so this feel unnecessary

let inclusionFee = 0.00001

return scaledExecutionFee + storageFee + inclusionFee
}

/// getNextIDAndIncrement returns the next ID and increments the ID counter
Expand Down
Loading