Add inclusion fee for scheduled transactions #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let storageFee = FlowStorageFees.storageCapacityToFlow(dataSizeMB) | ||
|
|
||
| return scaledExecutionFee + storageFee | ||
| // Add inclusion Flow fee for scheduled transactions |
There was a problem hiding this comment.
Wouldn't this be better to just include in the FlowFees.computeFees call in calculateFees(). We can just use a higher inclusion effort there
There was a problem hiding this comment.
Yeah but that wouldn't really be a base fee since it would depend on the priority. This felt to me more natural to think, like X is always minimum what you have to pay (no matter priority). But I'm open to change if you feel strongly against. How do you feel about the amount btw?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add inclusion fee for scheduled transactions in order to incentivize scheduling single transaction vs multiple.