chore: enforce erasable syntax where possible #3795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
requested review from
acoates-ms,
JasonVMo and
Saadnajmi
as code owners
github-actions
bot
added
feature: metro
tido64
force-pushed
the
tido/erasable-syntax/1
branch
from
cbe49f8 to
4f69b83
Compare
tido64
force-pushed
the
tido/erasable-syntax/1
branch
from
4f69b83 to
c59210d
Compare
JasonVMo
approved these changes
Sep 26, 2025
There was a problem hiding this comment.
This looks good. One comment is that we actually might want to deprecate the tsconfig.esm.node.json. The tsconfig.node.json actually will output esm if you set type: "module" in package.json. That's part of what node16 module/moduleResolution settings do. When you set the module to esnext you can't use the more powerful node16 moduleResolution setting so it is actually less functional.
Saadnajmi
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enforce erasable syntax where possible
Test plan
CI should pass