chore: enforce erasable syntax where possible (#3795)

tido64 · web-flow · commit 58ecee5a2c65 · 2025-09-29T10:21:54.000+02:00
diff --git a/.changeset/nasty-socks-fold.md b/.changeset/nasty-socks-fold.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/incubator/#archived/esbuild-bundle-analyzer/tsconfig.json b/incubator/#archived/esbuild-bundle-analyzer/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/incubator/#archived/patcher-rnmacos/tsconfig.json b/incubator/#archived/patcher-rnmacos/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/incubator/#archived/react-native-error-trace-decorator/tsconfig.json b/incubator/#archived/react-native-error-trace-decorator/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/incubator/@react-native-webapis/battery-status/tsconfig.json b/incubator/@react-native-webapis/battery-status/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "compilerOptions": {
     "lib": ["ES2021", "DOM"]
   },
diff --git a/incubator/@react-native-webapis/web-storage/tsconfig.json b/incubator/@react-native-webapis/web-storage/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "compilerOptions": {
     "lib": ["ES2021", "DOM"]
   },
diff --git a/incubator/build-plugin-firebase/tsconfig.json b/incubator/build-plugin-firebase/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.esm.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.esm.node.json",
   "include": ["src"]
 }
diff --git a/incubator/build/tsconfig.json b/incubator/build/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.esm.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.esm.node.json",
   "include": ["src"]
 }
diff --git a/incubator/polyfills/tsconfig.json b/incubator/polyfills/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/incubator/rn-changelog-generator/tsconfig.json b/incubator/rn-changelog-generator/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "compilerOptions": {
     "lib": ["ES2019.Object"],
     "alwaysStrict": false
diff --git a/incubator/yarn-plugin-dynamic-extensions/tsconfig.json b/incubator/yarn-plugin-dynamic-extensions/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.esm.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.esm.node.json",
   "compilerOptions": {
     "target": "esnext",
     "module": "nodenext",
diff --git a/packages/babel-plugin-import-path-remapper/tsconfig.json b/packages/babel-plugin-import-path-remapper/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "compilerOptions": {
     "noEmit": true
   },
diff --git a/packages/babel-preset-metro-react-native/test/__fixtures__/App.ts b/packages/babel-preset-metro-react-native/test/__fixtures__/App.ts
@@ -1,5 +1,6 @@
 require("typescript/lib/remap-test/lib/lib");
 
+// @ts-expect-error Intentional use of non-erasable syntax
 // eslint-disable-next-line @rnx-kit/no-const-enum
 const enum Direction {
   Up,
diff --git a/packages/babel-preset-metro-react-native/tsconfig.json b/packages/babel-preset-metro-react-native/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "compilerOptions": {
     "noEmit": true
   },
diff --git a/packages/bundle-diff/tsconfig.json b/packages/bundle-diff/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/commitlint-lite/tsconfig.json b/packages/commitlint-lite/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.esm.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.esm.node.json",
   "include": ["src"]
 }
diff --git a/packages/config/src/bundleConfig.ts b/packages/config/src/bundleConfig.ts
@@ -2,7 +2,7 @@ import type { PluginOptions as CyclicDetectorOptions } from "@rnx-kit/metro-plug
 import type { Options as DuplicateDetectorOptions } from "@rnx-kit/metro-plugin-duplicates-checker";
 import type { Options as EsbuildOptions } from "@rnx-kit/metro-serializer-esbuild";
 import type { AllPlatforms } from "@rnx-kit/tools-react-native/platform";
-import type { OutputOptions } from "metro/src/shared/types";
+import type { OutputOptions } from "metro/private/shared/types";
 
 export type HermesOptions = {
   /**
diff --git a/packages/config/tsconfig.json b/packages/config/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"],
   "exclude": ["src/__fixtures__/**/*", "src/__snapshots__/**/*"]
 }
diff --git a/packages/console/tsconfig.json b/packages/console/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/esbuild-plugin-import-path-remapper/tsconfig.json b/packages/esbuild-plugin-import-path-remapper/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"],
   "compilerOptions": {
     "outDir": "lib"
diff --git a/packages/eslint-plugin/src/rules/no-export-all.js b/packages/eslint-plugin/src/rules/no-export-all.js
@@ -2,7 +2,7 @@
 "use strict";
 
 /**
- * @typedef {import("@typescript-eslint/types/dist/index").TSESTree.Node} Node
+ * @typedef {import("@typescript-eslint/types").TSESTree.Node} Node
  * @typedef {import("eslint").Linter.Config} Config
  * @typedef {import("eslint").Rule.RuleContext} ESLintRuleContext
  * @typedef {import("eslint").Rule.ReportFixer} ESLintReportFixer
diff --git a/packages/eslint-plugin/tsconfig.json b/packages/eslint-plugin/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "compilerOptions": {
     "noEmit": true
   },
diff --git a/packages/jest-preset/tsconfig.json b/packages/jest-preset/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "compilerOptions": {
     "noEmit": true
   },
diff --git a/packages/metro-config/src/assetPluginForMonorepos.js b/packages/metro-config/src/assetPluginForMonorepos.js
@@ -3,7 +3,7 @@
  * @typedef {import("metro-config").ConfigT} ConfigT;
  * @typedef {import("metro-config").Middleware} Middleware;
  *
- * @typedef {import("metro/src/Server").default & {
+ * @typedef {import("metro/private/Server").default & {
  *   _config?: ConfigT;
  * }} Server;
  */
diff --git a/packages/metro-config/test/assetPluginForMonorepos.test.ts b/packages/metro-config/test/assetPluginForMonorepos.test.ts
@@ -1,6 +1,6 @@
 import type { AssetData } from "metro";
 import type { Middleware } from "metro-config";
-import type Server from "metro/src/Server";
+import type Server from "metro/private/Server";
 import { equal } from "node:assert/strict";
 import type { IncomingMessage, ServerResponse } from "node:http";
 import { describe, it } from "node:test";
diff --git a/packages/metro-config/tsconfig.json b/packages/metro-config/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "compilerOptions": {
     "noEmit": true
   },
diff --git a/packages/metro-plugin-cyclic-dependencies-detector/tsconfig.json b/packages/metro-plugin-cyclic-dependencies-detector/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/metro-plugin-duplicates-checker/tsconfig.json b/packages/metro-plugin-duplicates-checker/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/metro-plugin-typescript/tsconfig.json b/packages/metro-plugin-typescript/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/metro-resolver-symlinks/src/index.ts b/packages/metro-resolver-symlinks/src/index.ts
@@ -1,5 +1,3 @@
 import { makeResolver } from "./symlinkResolver";
 
-// `export =` is not supported by @babel/plugin-transform-typescript.
-// For anything that needs to be tested, please put them elsewhere.
-export = makeResolver;
+module.exports = makeResolver;
diff --git a/packages/metro-resolver-symlinks/tsconfig.json b/packages/metro-resolver-symlinks/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/metro-serializer/tsconfig.json b/packages/metro-serializer/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/metro-service/src/bundle.ts b/packages/metro-service/src/bundle.ts
@@ -54,7 +54,7 @@ export function bundle(
   // https://github.com/facebook/metro/commit/a0f99e136fbd2e02ab070437cee9f6e9baa36d16
   const { runMetro } = requireModuleFromMetro("metro", config.projectRoot);
   if (!runMetro) {
-    return import("./bundle/bundle-0.66").then(({ buildBundle }) =>
+    return import("./bundle/bundle-0.66.js").then(({ buildBundle }) =>
       buildBundle(args, config, output, {
         entryFile: args.entryFile,
         sourceMapUrl,
@@ -66,7 +66,7 @@ export function bundle(
     );
   }
 
-  return import("./bundle/bundle-0.71").then(({ buildBundle }) => {
+  return import("./bundle/bundle-0.71.js").then(({ buildBundle }) => {
     const sourceMap = args.sourcemapOutput != null;
     return buildBundle(args, config, output, {
       dev: args.dev,
diff --git a/packages/metro-service/src/bundle/bundle-0.66.ts b/packages/metro-service/src/bundle/bundle-0.66.ts
@@ -9,7 +9,7 @@ import type { BundleArgs, RequestOptions } from "../types";
 export async function buildBundle(
   args: BundleArgs,
   config: ConfigT,
-  output: typeof import("metro/src/shared/output/bundle"),
+  output: typeof import("metro/private/shared/output/bundle"),
   requestOpts: RequestOptions
 ): Promise<void> {
   const Server = requireModuleFromMetro("metro/src/Server", config.projectRoot);
@@ -24,6 +24,7 @@ export async function buildBundle(
     const outputAssets = await server.getAssets({
       ...Server.DEFAULT_BUNDLE_OPTIONS,
       ...requestOpts,
+      // @ts-expect-error 'bundleType' existed in older versions of 'BundleOptions'
       bundleType: "todo",
     });
 
diff --git a/packages/metro-service/src/bundle/bundle-0.71.ts b/packages/metro-service/src/bundle/bundle-0.71.ts
@@ -2,12 +2,12 @@ import { warn } from "@rnx-kit/console";
 import { requireModuleFromMetro } from "@rnx-kit/tools-react-native/metro";
 import type { AssetData } from "metro";
 import type { ConfigT } from "metro-config";
-import type Server from "metro/src/Server";
+import type Server from "metro/private/Server";
 import { getSaveAssetsPlugin } from "../asset/saveAssets";
 import { saveAssets } from "../asset/write";
 import type { BundleArgs, RequestOptions } from "../types";
 
-type MetroBundle = typeof import("metro/src/shared/output/bundle");
+type MetroBundle = typeof import("metro/private/shared/output/bundle");
 
 type BuildOutput = Awaited<ReturnType<MetroBundle["build"]>>;
 
@@ -56,6 +56,7 @@ export async function buildBundle(
       const outputOptions = { bundleOutput, sourcemapOutput, dev, platform };
       await output.save(metroBundle, outputOptions, (message) =>
         config.reporter.update({
+          // @ts-expect-error 'bundle_save_log' was introduced in Metro 0.81.1
           type: "bundle_save_log",
           message,
         })
diff --git a/packages/metro-service/src/terminal.ts b/packages/metro-service/src/terminal.ts
@@ -1,6 +1,6 @@
 import { requireModuleFromMetro } from "@rnx-kit/tools-react-native/metro";
 import type { Terminal } from "metro-core";
-import type { TerminalReporter } from "metro/src/lib/TerminalReporter";
+import type { TerminalReporter } from "metro/private/lib/TerminalReporter";
 
 export type MetroTerminal = {
   terminal: Terminal;
diff --git a/packages/metro-service/src/types.ts b/packages/metro-service/src/types.ts
@@ -1,4 +1,4 @@
-import type { BundleOptions, OutputOptions } from "metro/src/shared/types";
+import type { BundleOptions, OutputOptions } from "metro/private/shared/types";
 
 export type BundleArgs = {
   assetsDest?: string;
diff --git a/packages/metro-service/tsconfig.json b/packages/metro-service/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/react-native-auth/tsconfig.json b/packages/react-native-auth/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "compilerOptions": {
     "checkJs": false
   },
diff --git a/packages/react-native-lazy-index/tsconfig.json b/packages/react-native-lazy-index/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "compilerOptions": {
     "noEmit": true
   },
diff --git a/packages/template/tsconfig.json b/packages/template/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/test-app/tsconfig.json b/packages/test-app/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "compilerOptions": {
     "checkJs": false,
     "noEmit": true,
diff --git a/packages/third-party-notices/tsconfig.json b/packages/third-party-notices/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/tools-android/tsconfig.json b/packages/tools-android/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.esm.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.esm.node.json",
   "include": ["src"]
 }
diff --git a/packages/tools-apple/tsconfig.json b/packages/tools-apple/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.esm.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.esm.node.json",
   "include": ["src"]
 }
diff --git a/packages/tools-language/tsconfig.json b/packages/tools-language/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/tools-node/tsconfig.json b/packages/tools-node/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/tools-packages/tsconfig.json b/packages/tools-packages/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.node.json",
   "include": ["src"]
 }
diff --git a/packages/tools-shell/tsconfig.json b/packages/tools-shell/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.esm.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.esm.node.json",
   "include": ["src"]
 }
diff --git a/packages/tools-windows/tsconfig.json b/packages/tools-windows/tsconfig.json
@@ -1,4 +1,4 @@
 {
-  "extends": "@rnx-kit/tsconfig/tsconfig.esm.json",
+  "extends": "@rnx-kit/tsconfig/tsconfig.esm.node.json",
   "include": ["src"]
 }
diff --git a/packages/tools-workspaces/src/common.ts b/packages/tools-workspaces/src/common.ts
@@ -1,9 +1,9 @@
 import type { Options } from "fast-glob";
 import fg from "fast-glob";
 import findUp from "find-up";
-import { readFileSync } from "fs";
-import { readFile } from "fs/promises";
-import * as path from "path";
+import { readFileSync } from "node:fs";
+import { readFile } from "node:fs/promises";
+import * as path from "node:path";
 import stripJsonComments from "strip-json-comments";
 
 type PackageManager = {
@@ -85,16 +85,16 @@ export function getImplementation(sentinel: string): Promise<PackageManager> {
     case BUN_LOCKB: // fallthrough — logic defining workspaces config is the same as for npm and yarn
     case PACKAGE_LOCK_JSON: // fallthrough — logic defining workspaces config is the same for npm and yarn
     case YARN_LOCK:
-      return import("./yarn");
+      return import("./yarn.js");
 
     case LERNA_JSON:
-      return import("./lerna");
+      return import("./lerna.js");
 
     case PNPM_WORKSPACE_YAML:
-      return import("./pnpm");
+      return import("./pnpm.js");
 
     case RUSH_JSON:
-      return import("./rush");
+      return import("./rush.js");
   }
 
   throw new Error(
diff --git a/packages/tools-workspaces/src/index.ts b/packages/tools-workspaces/src/index.ts
diff --git a/packages/tools-workspaces/src/info.ts b/packages/tools-workspaces/src/info.ts
diff --git a/packages/tools-workspaces/src/lerna.ts b/packages/tools-workspaces/src/lerna.ts
diff --git a/packages/tools-workspaces/src/pnpm.ts b/packages/tools-workspaces/src/pnpm.ts
diff --git a/packages/tools-workspaces/src/rush.ts b/packages/tools-workspaces/src/rush.ts
diff --git a/packages/tools-workspaces/src/yarn.ts b/packages/tools-workspaces/src/yarn.ts
diff --git a/packages/tools-workspaces/tsconfig.json b/packages/tools-workspaces/tsconfig.json
diff --git a/packages/typescript-service/tsconfig.json b/packages/typescript-service/tsconfig.json
diff --git a/scripts/tsconfig.json b/scripts/tsconfig.json

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`		`- "extends": "@rnx-kit/tsconfig/tsconfig.json",`
	`2`	`+ "extends": "@rnx-kit/tsconfig/tsconfig.node.json",`
`3`	`3`	`"include": ["src"]`
`4`	`4`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`		`- "extends": "@rnx-kit/tsconfig/tsconfig.json",`
	`2`	`+ "extends": "@rnx-kit/tsconfig/tsconfig.node.json",`
`3`	`3`	`"compilerOptions": {`
`4`	`4`	`"lib": ["ES2021", "DOM"]`
`5`	`5`	`},`