Skip to content

Fix flaky test in MetricRegistryImplTest #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix flaky test in MetricRegistryImplTest #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions metrics/src/test/java/com/google/monitoring/metrics/MetricRegistryImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.google.common.collect.ImmutableSet;
import com.google.monitoring.metrics.MetricSchema.Kind;
import org.junit.After;
import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
Expand All @@ -38,6 +39,16 @@ public class MetricRegistryImplTest {
private final LabelDescriptor label =
LabelDescriptor.create("test_labelname", "test_labeldescription");

/**
* Add {@code unregisterAllMetrics} before the class
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use @link #unregisterAllMetrics instead?

* in case metrics not unregistered at the beginning
* and cause flaky test
*/
@BeforeClass
public static void beforeClassClearMetrics() {
MetricRegistryImpl.getDefault().unregisterAllMetrics();
}

@After
public void clearMetrics() {
MetricRegistryImpl.getDefault().unregisterAllMetrics();
Expand Down