Skip to content

Conversation

KellyShao
Copy link

Fixed flaky test that caused by MetricRegistryImpl in com.google.monitoring.metrics.MetricRegistryImplTest.java.

Existing tests are flaky because the MetricRegistryImpl doesn't clear metrics at the beginning of this class.

The flaky tests are found by running https://github.com/idflakies/iDFlakies

@google-cla
Copy link

google-cla bot commented Nov 9, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@KellyShao
Copy link
Author

@googlebot I signed it!

Copy link
Contributor

@jianglai jianglai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kelly,

Thanks for the contribution! Sorry I was on leave for a while. I've made a small suggestion. Everything else seems good.

LabelDescriptor.create("test_labelname", "test_labeldescription");

/**
* Add {@code unregisterAllMetrics} before the class
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use @link #unregisterAllMetrics instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants