Skip to content

25-3-1: Use a separate alerts_exception counter for unhandled exceptions #26843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

25-3-1: Use a separate alerts_exception counter for unhandled exceptions #26843

merged 1 commit into from
Oct 15, 2025
+2 −1

Conversation

snaury
Copy link
Member

@snaury snaury commented Oct 14, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Unhandled exceptions need a separate counter since it's a much more severe than other Broken() calls in executor.

@snaury snaury self-assigned this Oct 14, 2025
@snaury snaury marked this pull request as ready for review October 14, 2025 12:04
@snaury snaury requested a review from a team as a code owner October 14, 2025 12:04
@snaury snaury enabled auto-merge October 14, 2025 12:05
@github-actions GitHub Actions
Copy link

🟢 2025-10-14 12:06:01 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

⚪ 2025-10-14 12:06:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for ed7900f has started.
⚪ 2025-10-14 12:06:23 UTC Artifacts will be uploaded here
⚪ 2025-10-14 12:09:55 UTC ya make is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2025 •
edited
Loading

⚪ 2025-10-14 12:08:19 UTC Pre-commit check linux-x86_64-release-asan for ed7900f has started.
⚪ 2025-10-14 12:08:32 UTC Artifacts will be uploaded here
⚪ 2025-10-14 12:12:07 UTC ya make is running...
🟡 2025-10-14 14:25:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15880 15461 0 162 240 17

🟢 2025-10-14 14:26:21 UTC Build successful.
🟢 2025-10-14 14:26:44 UTC ydbd size 3.8 GiB changed* by +6.2 KiB, which is < 100.0 KiB vs stable-25-3-1: OK

ydbd size dash stable-25-3-1: 7069837 merge: ed7900f diff diff %
ydbd size 4 046 620 936 Bytes 4 046 627 272 Bytes +6.2 KiB +0.000%
ydbd stripped size 1 507 495 712 Bytes 1 507 497 504 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@PavelEfarinov PavelEfarinov added the rebase-and-check Rebase PR with the current base branch and check label Oct 15, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 09:49:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5f54fc3 has started.
⚪ 2025-10-15 09:50:04 UTC Artifacts will be uploaded here
⚪ 2025-10-15 09:53:46 UTC ya make is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 09:55:28 UTC Pre-commit check linux-x86_64-release-asan for 5f54fc3 has started.
⚪ 2025-10-15 09:55:42 UTC Artifacts will be uploaded here
⚪ 2025-10-15 09:59:17 UTC ya make is running...
🟡 2025-10-15 12:07:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15880 15148 0 365 345 22

🟢 2025-10-15 12:09:01 UTC Build successful.
🟢 2025-10-15 12:09:25 UTC ydbd size 3.8 GiB changed* by +6.2 KiB, which is < 100.0 KiB vs stable-25-3-1: OK

ydbd size dash stable-25-3-1: 7069837 merge: 5f54fc3 diff diff %
ydbd size 4 046 620 936 Bytes 4 046 627 272 Bytes +6.2 KiB +0.000%
ydbd stripped size 1 507 495 712 Bytes 1 507 497 504 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury added the rebase-and-check Rebase PR with the current base branch and check label Oct 15, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 15:24:17 UTC Pre-commit check linux-x86_64-release-asan for 1ded4d5 has started.
⚪ 2025-10-15 15:24:31 UTC Artifacts will be uploaded here
⚪ 2025-10-15 15:28:03 UTC ya make is running...
🟡 2025-10-15 17:37:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15881 15430 0 175 259 17

🟢 2025-10-15 17:38:25 UTC Build successful.
🟢 2025-10-15 17:38:48 UTC ydbd size 3.8 GiB changed* by +93.9 KiB, which is < 100.0 KiB vs stable-25-3-1: OK

ydbd size dash stable-25-3-1: 2335fbd merge: 1ded4d5 diff diff %
ydbd size 4 046 616 968 Bytes 4 046 713 088 Bytes +93.9 KiB +0.002%
ydbd stripped size 1 507 491 680 Bytes 1 507 532 064 Bytes +39.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

⚪ 2025-10-15 15:24:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1ded4d5 has started.
⚪ 2025-10-15 15:24:34 UTC Artifacts will be uploaded here
⚪ 2025-10-15 15:28:08 UTC ya make is running...
🟡 2025-10-15 17:02:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38551 35871 0 6 2650 24

⚪ 2025-10-15 17:05:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-15 17:32:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
589 (only retried tests) 569 0 1 0 19

⚪ 2025-10-15 17:32:37 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-10-15 17:53:30 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
541 (only retried tests) 525 0 1 0 15

🟢 2025-10-15 17:53:38 UTC Build successful.
🟢 2025-10-15 17:53:57 UTC ydbd size 2.3 GiB changed* by +54.2 KiB, which is < 100.0 KiB vs stable-25-3-1: OK

ydbd size dash stable-25-3-1: 2335fbd merge: 1ded4d5 diff diff %
ydbd size 2 432 132 152 Bytes 2 432 187 656 Bytes +54.2 KiB +0.002%
ydbd stripped size 521 005 384 Bytes 521 021 320 Bytes +15.6 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk disabled auto-merge October 15, 2025 20:19
@maximyurchuk maximyurchuk merged commit 6ab0a13 into ydb-platform:stable-25-3-1 Oct 15, 2025
18 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximyurchuk maximyurchuk maximyurchuk approved these changes

Assignees

@snaury snaury

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snaury @maximyurchuk @PavelEfarinov