-
Notifications
You must be signed in to change notification settings - Fork 724
Dev change compat flag #26808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Dev change compat flag #26808
Conversation
🟢 |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
@@ -175,9 +176,16 @@ def create_driver(self): | |||
return driver | |||
|
|||
def setup_cluster(self, tenant_db=None, **kwargs): | |||
has_current_version = any( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Мне кажется условие странное
Я бы лучше наоборот написал: если все версии "номерные", то выставлять suppress_version_check не надо
А сейчас у тебя идет полагание, что inf это current, наверное хотелось бы избежать этого
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тогда предлагаю проверку вида "все версии теста - целочисленные"
all_versions_numbered = all(
# +inf == current will be float, all other versions are int
isinstance(item, int)
for tpl in self.versions
for item in tpl
)
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ ⚪ Ya make output | Test bloat | Test bloat
⚪ Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
78a8ccf
to
df5b5a8
Compare
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog category
Description for reviewers
Включаем для
MixudClusterFixture
проверки совместимости версий при условии, что обе версии неcurrent
Проверочный прогон