Skip to content

Conversation

PavelEfarinov
Copy link
Collaborator

@PavelEfarinov PavelEfarinov commented Oct 14, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Включаем для MixudClusterFixture проверки совместимости версий при условии, что обе версии не current

Проверочный прогон

Copy link

github-actions bot commented Oct 14, 2025

🟢 2025-10-14 08:05:04 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Oct 14, 2025

2025-10-14 08:05:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 667415e has started.
2025-10-14 08:06:07 UTC Artifacts will be uploaded here
2025-10-14 08:08:41 UTC ya make is running...
🟢 2025-10-14 08:21:49 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
47 47 0 0 0 0

🟢 2025-10-14 08:21:52 UTC Build successful.
🟡 2025-10-14 08:22:03 UTC ydbd size 2.3 GiB changed* by +1.3 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: e165956 merge: 667415e diff diff %
ydbd size 2 420 169 840 Bytes 2 421 544 352 Bytes +1.3 MiB +0.057%
ydbd stripped size 515 420 200 Bytes 515 624 392 Bytes +199.4 KiB +0.040%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 14, 2025

2025-10-14 08:10:44 UTC Pre-commit check linux-x86_64-release-asan for 667415e has started.
2025-10-14 08:10:58 UTC Artifacts will be uploaded here
2025-10-14 08:13:42 UTC ya make is running...
🟢 2025-10-14 08:28:30 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35 35 0 0 0 0

🟢 2025-10-14 08:28:33 UTC Build successful.
🔴 2025-10-14 08:28:47 UTC ydbd size 3.8 GiB changed* by +2.9 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 0838744 merge: 667415e diff diff %
ydbd size 4 025 906 368 Bytes 4 028 989 608 Bytes +2.9 MiB +0.077%
ydbd stripped size 1 495 250 944 Bytes 1 496 756 416 Bytes +1.4 MiB +0.101%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@@ -175,9 +176,16 @@ def create_driver(self):
return driver

def setup_cluster(self, tenant_db=None, **kwargs):
has_current_version = any(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне кажется условие странное

Я бы лучше наоборот написал: если все версии "номерные", то выставлять suppress_version_check не надо

А сейчас у тебя идет полагание, что inf это current, наверное хотелось бы избежать этого

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тогда предлагаю проверку вида "все версии теста - целочисленные"

        all_versions_numbered = all(
            # +inf == current will be float, all other versions are int
            isinstance(item, int)
            for tpl in self.versions
            for item in tpl
        )

Copy link

github-actions bot commented Oct 15, 2025

2025-10-15 08:51:37 UTC Pre-commit check linux-x86_64-release-asan for 7880f77 has started.
2025-10-15 08:51:51 UTC Artifacts will be uploaded here
2025-10-15 08:54:28 UTC ya make is running...
🟡 2025-10-15 08:57:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35 34 0 1 0 0

🟢 2025-10-15 08:57:39 UTC Build successful.
🟢 2025-10-15 08:57:53 UTC ydbd size 3.8 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a116ac4 merge: 7880f77 diff diff %
ydbd size 4 032 935 280 Bytes 4 032 938 432 Bytes +3.1 KiB +0.000%
ydbd stripped size 1 497 801 344 Bytes 1 497 802 592 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 15, 2025

2025-10-15 08:51:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7880f77 has started.
2025-10-15 08:52:08 UTC Artifacts will be uploaded here
2025-10-15 08:54:47 UTC ya make is running...
🟡 2025-10-15 08:59:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
47 46 0 1 0 0

2025-10-15 08:59:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-10-15 09:00:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

2025-10-15 09:00:59 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-10-15 09:02:03 UTC Some tests failed, follow the links below.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2 (only retried tests) 1 0 1 0 0

🟢 2025-10-15 09:02:05 UTC Build successful.
🟢 2025-10-15 09:02:16 UTC ydbd size 2.3 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a116ac4 merge: 7880f77 diff diff %
ydbd size 2 423 988 336 Bytes 2 423 990 320 Bytes +1.9 KiB +0.000%
ydbd stripped size 515 997 032 Bytes 515 997 480 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@PavelEfarinov PavelEfarinov force-pushed the dev-change-compat-flag branch from 78a8ccf to df5b5a8 Compare October 15, 2025 09:31
Copy link

github-actions bot commented Oct 15, 2025

2025-10-15 09:33:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for a3b2528 has started.
2025-10-15 09:33:31 UTC Artifacts will be uploaded here
2025-10-15 09:36:02 UTC ya make is running...
🟢 2025-10-15 09:37:25 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
47 47 0 0 0 0

🟢 2025-10-15 09:37:27 UTC Build successful.
🟢 2025-10-15 09:37:38 UTC ydbd size 2.3 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a116ac4 merge: a3b2528 diff diff %
ydbd size 2 423 988 336 Bytes 2 423 990 320 Bytes +1.9 KiB +0.000%
ydbd stripped size 515 997 032 Bytes 515 997 480 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 15, 2025

2025-10-15 09:33:53 UTC Pre-commit check linux-x86_64-release-asan for a3b2528 has started.
2025-10-15 09:34:07 UTC Artifacts will be uploaded here
2025-10-15 09:36:42 UTC ya make is running...
🟢 2025-10-15 09:38:10 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35 35 0 0 0 0

🟢 2025-10-15 09:38:12 UTC Build successful.
🟢 2025-10-15 09:38:27 UTC ydbd size 3.8 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a116ac4 merge: a3b2528 diff diff %
ydbd size 4 032 935 280 Bytes 4 032 938 432 Bytes +3.1 KiB +0.000%
ydbd stripped size 1 497 801 344 Bytes 1 497 802 592 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants