Skip to content

Conversation

layoutd
Copy link
Contributor

@layoutd layoutd commented Oct 2, 2025

This pull request updates a development dependency version in the composer.json file to keep the project up-to-date.

  • Dependency update:
    • Upgraded the sirbrillig/phpcs-changed package from version ^2.10.2 to ^2.11.8 in the require-dev section of composer.json.

All Submissions:

Changes proposed in this Pull Request:

To avoid deprecated errors in PHP 8.4:

Deprecated: PhpcsChanged\Cli\shouldIgnorePath(): Implicitly marking parameter $patternOption as nullable is deprecated, the explicit nullable type must be used instead in /…/wc-smooth-generator/vendor/sirbrillig/phpcs-changed/PhpcsChanged/Cli.php on line 465
  • Dependency update: Upgraded the sirbrillig/phpcs-changed package from version ^2.10.2 to ^2.11.8 in the require-dev section of composer.json.

How to test the changes in this Pull Request:

  1. Using PHP 8.4, generate orders or products wp wc generate orders 5
  2. In trunk, notice the deprecation error.
  3. In this branch (after composer install), no deprecation error should be visible (from this plugin, at least).

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@layoutd layoutd self-assigned this Oct 2, 2025
@layoutd layoutd requested a review from Copilot October 2, 2025 22:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the development dependency sirbrillig/phpcs-changed to resolve PHP 8.4 deprecation warnings.

  • Bump sirbrillig/phpcs-changed from ^2.10.2 to ^2.11.8 in composer.json require-dev
  • Ensures compatibility to avoid deprecated parameter warning in PHP 8.4

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@layoutd layoutd merged commit 9cd7ba6 into trunk Oct 6, 2025
@layoutd layoutd deleted the fix/bump-phpcs-changed branch October 6, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant