Skip to content

feat: highlight active backend service with logo border #12540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: highlight active backend service with logo border #12540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/components/BrandLogo.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ export interface Props {
size?: `${number}rem` | `${number}px`;
shape?: 'circle' | 'rounded';
brand: LogoKey;
'data-current'?: boolean;
}

const { brand, size = '4rem', shape = 'circle' } = Astro.props as Props;
const { brand, size = '4rem', shape = 'circle', 'data-current': dataCurrent } = Astro.props as Props;
const { file, padding } = logos[brand] || {};

// Make a rough guess at the pixel size to use as width/height attributes
Expand All @@ -18,7 +19,7 @@ const pixelSize = unit === 'px' ? valueAsNumber : valueAsNumber * 16;

{
file && (
<div class:list={['logo', shape]} style={`--logo-size: ${size}; --logo-padding: ${padding};`}>
<div class:list={['logo', shape]} style={`--logo-size: ${size}; --logo-padding: ${padding};`} data-current={dataCurrent}>
<img
src={`/logos/${file}`}
alt=""
Expand Down Expand Up @@ -59,4 +60,10 @@ const pixelSize = unit === 'px' ? valueAsNumber : valueAsNumber * 16;
width: 100%;
height: 100%;
}

/* Active state styling */
.logo[data-current="true"] {
border: 4px solid var(--sl-color-text-accent);
transform: scale(1.05);
}
</style>
4 changes: 2 additions & 2 deletions src/components/NavGrid/Card.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ export interface Props extends HTMLAttributes<'li'> {
const { href, logo, current, minimal, class: classes, ...attrs } = Astro.props as Props;
---

<li class:list={['card', minimal && 'card--minimal', classes]} {...attrs}>
{logo && <BrandLogo brand={logo} />}
<li class:list={['card', minimal && 'card--minimal', current && 'card--current', classes]} {...attrs}>
{logo && <BrandLogo brand={logo} data-current={current} />}
<div class="stack sl-flex">
<h3>
<a href={href} aria-current={current ? 'page' : 'false'}>
Expand Down
2 changes: 1 addition & 1 deletion src/components/NavGrid/CardsNav.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const currentPage = new URL(Astro.request.url).pathname;
links.map(({ description, href, logo, title, tags, lang }) => (
<Card
{...{ minimal, logo, href, lang }}
current={currentPage.includes(href)}
current={currentPage === href || currentPage.startsWith(href + '/')}
class={Object.keys(tags || {}).join(' ')}
>
<Fragment slot="title" set:html={title} />
Expand Down
Loading