Added feature keep cookie preferences #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nces in session while managing preferences
There was a problem hiding this comment.
This PR will not be merged in its current state since it will need a different approach. @Debatty-Tom we'll discuss this internally, based on the outputs of PRs #96 & #99.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover #58 adding edit action on cookie consent button.
In the controller, I set up a new temporary cookie which gives me true or false for each category depending on the user preferences.
I pass this information to the view with the Cookie Manager and delete the temporary cookie just after that. And I can finally toggle on the front the categories that were previously toggled.