-
-
Notifications
You must be signed in to change notification settings - Fork 236
Add date range support to access control rules #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7432ad
to
44ee362
Compare
tw4l
commented
Aug 1, 2025
tw4l
commented
Aug 1, 2025
Looks great! Would be good to have a slightly more complex test case, with multiple entries or multiple paths to ensure that path matching is working as expected |
53153e3
to
d581da8
Compare
53c7c4d
to
80e781b
Compare
This is great news - looking forward to testing it! |
0x1b5b
pushed a commit
to 0x1b5b/pywb
that referenced
this pull request
Oct 22, 2025
* Implement access rule date support for before, after, newer , older * Add documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #703
This PR adds date range support to ACL rules that uses the existing embargo syntax.
Access can be controlled by specifying
before
orafter
a particular timestamp, e.g.Time intervals can also be used via
newer
andolder
, e.g.:Documentation has also been added.
Motivation and Context
This will allow users to block/allow a subset of captures from a URL based on date, e.g. in the case where ownership of a URL changed at some point.
Types of changes
Checklist: