feat: update default externalsType as commonjs-import
#605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default externals type from dynamic selection between 'commonjs'/'import' or 'commonjs'/'module-import' to a fixed 'commonjs-import' type across all configurations. The change simplifies external module handling by using a single consistent format that supports both CommonJS and ES module imports.
- Replaces conditional dependency type logic with fixed 'commonjs-import' external type
- Sets default externalsType configuration to 'commonjs-import'
- Updates built-in module handling to use builtinModules array instead of isBuiltin function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/core/plugins/external.ts | Updates external module resolution logic to use 'commonjs-import' type consistently and refactors built-in module detection |
| packages/core/tests/core/snapshots/rsbuild.test.ts.snap | Updates test snapshots to reflect new externalsType configuration and expanded built-in modules list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
update default externalsType as
commonjs-import.https://rspack.rs/config/externals#externalstypecommonjs-import
Related Links
Checklist