updating watcher task functions to be cleaner, inspired by other PR #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will re-organize the task base to include a single entrypoint to the functions to write data to file. I made this decision based on doing similar in #32, which I'm not sure is going to be merged, and wanted to maintain the nice organization here. Specifically, instead of having custom parsing done by the watcher, we allow it to be run (and then custom defined) by the task. This way, a special kind of task can choose to parse data in a custom way.
I'm also experimenting with flake8, and am considering adding it (but possibly after this merge to not be too much in one PR).
Signed-off-by: Vanessa Sochat vsochat@stanford.edu