Type specific Map#foreach

[viciscat]

Title says it all.

I also tried doing a custom implementation of forEach in OpenHashMap to remove that one allocation of MapEntry but I don't know if that's wanted.
Didn't do many javadoc.

[viciscat]

Ok didn't expect it to be merged, thought some more things would be needed 😅

[vigna]

Oh well. Which things?

[viciscat]

doing a custom implementation of forEach for the other maps like what I did in OpenHashMap and better javadoc I guess? pretty sure I didn't put any on the type specific forEach

[vigna]

I'm not at a computer, but isn't there some in the interface? Now you'll tell me there's no interface 😆

[viciscat]

Yea there's no interface 😉
For real though, there's no javadoc for the forEach(EntryConsumer) method at line 321, all the others do though

[vigna]

You tricked me 😆. Well it shouldn't be difficult to write a default method. I could ask Jules in fact.

[vigna]

I also tried doing a custom implementation of forEach in OpenHashMap to remove that one allocation of MapEntry but I don't know if that's wanted. Didn't do many javadoc.

BTW the fast iterators for hash maps do exactly that—they reuse the entry.