Add some array builtins for more efficient array programming #5908
+2,042
−804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mismatching cases were doing sort of the opposite of intended
Previously it would stop joining when _either_ side was out of indices, but the opposite side might have some left overs that should extend the results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
UnboxedArraytype and various operations on it andImmutableArraythat allow for more efficient bulk operations on arrays. The array operations are described here.Most operations have just been added as new builtins, and will need to be wrapped in e.g.
@unsion/base. However, I addedImmutableArray.toList(a.k.aArray.Raw.toList) as a function replacement, because it was already a predef inIOSource.This could use some more thorough testing by @SystemFw and @pchiusano , but I'll add the examples from the spec as a transcript.