Render diff on a line by line basis #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unison-share-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hojberg
force-pushed
the
diff-alignment-integration
branch
2 times, most recently
from
bb80869 to
2e5c0a2
Compare
The API now sends back diffs on a line by line basis with spacers such that left and right side diffs can be aligned. Update the JSON decoders to support this new format and render the UI appropriately. Also add line numbers and change indicators in a diff gutter as well as line spacer patterns.
hojberg
force-pushed
the
diff-alignment-integration
branch
from
2e5c0a2 to
6369b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API now sends back diffs on a line by line basis with spacers such
that left and right side diffs can be aligned. Update the JSON decoders
to support this new format and render the UI appropriately.
Also add line numbers and change indicators in a diff gutter as well as
line spacer patterns.
Depends on unisonweb/unison#5925