Fix Create or replace Materialized view error in Iceberg #26730
+72
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
changed the title
codluca
force-pushed
the
25610-create-or-replace-materialized-view
branch
3 times, most recently
from
63371bc to
1e0aef9
Compare
The previous files for materialized views were not cleaned properly: - during view replace, the existing view was deleted after creating the new one, not before (this case caused the error from the trinodb#25610 issue), - during view drop, there was an attempt to delete the files twice (this case caused an error when dropping the materialized view). - some leftover metadata and data files remained after recreate Now, when recreating the materialized view, we are always deleting the existing storage using the dropMaterializedViewStorage method at the beginning of the process. The dropMaterializedViewStorage had an extra metastore.dropTable call, which caused the DROP error, as the metastore.dropTable call needed files that were deleted by the call before. In dropMaterializedViewStorage we are making sure the table is cleared from the metastore. Enabled some unit tests that were ignored before due to the existing issues.
codluca
force-pushed
the
25610-create-or-replace-materialized-view
branch
from
1e0aef9 to
9551001
Compare
|
The issue looks like not invalidate the cache |
|
Added invalidateTableCache call when deleting materialized view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Create or replace Materialized view error
Fixes #25610
Description
The previous files for materialized views were not cleaned properly:
Now, when recreating the materialized view, we are always deleting the existing storage using the dropMaterializedViewStorage method at the beginning of the process.
The dropMaterializedViewStorage had an extra metastore.dropTable call, which caused the DROP error, as the metastore.dropTable call needed files that were deleted by the call before.
In dropMaterializedViewStorage we are making sure the table is cleared from the metastore.
Enabled some unit tests that were ignored before due to the existing issues.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: