Skip to content

Conversation

GideonBear
Copy link
Member

What does this PR do

Closes #1289

Standards checklist

  • The PR title is descriptive
  • I have read CONTRIBUTING.md
  • Optional: I have tested the code myself
  • If this PR introduces new user-facing messages they are translated

@promisedlandt Could you test if this solves the issue?
cargo install --git https://github.com/GideonBear/topgrade --branch fix-guix
~/.cargo/bin/topgrade --only guix --dry-run and ~/.cargo/bin/topgrade --only guix

@promisedlandt
Copy link

Both dry-run and wet-run work as expected with this change.

Completely unrelated: with an only = [...] line in my config, the --only command line flag is ignored.

@GideonBear
Copy link
Member Author

Completely unrelated: with an only = [...] line in my config, the --only command line flag is ignored.

That should not be the case. It should compound, e.g. only = [ a ] and --only b should result in steps a, b running.

@promisedlandt
Copy link

Completely unrelated: with an only = [...] line in my config, the --only command line flag is ignored.

That should not be the case. It should compound, e.g. only = [ a ] and --only b should result in steps a, b running.

Very possible that's what happened then. I had guix both in my config and the flag.
I would have expected the flag to override the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guix pull does not respect --dry-run
2 participants