fix: add pagination for list incomplete tasks #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcristau
requested changes
Oct 7, 2025
abhishekmadan30
force-pushed
the
add-page
branch
from
562d5b4 to
c1b4349
Compare
jcristau
reviewed
Oct 7, 2025
test/test_util_taskcluster.py
Outdated
| {"status": {"taskId": "7", "state": "running"}}, | ||
| {"status": {"taskId": "8", "state": "completed"}}, | ||
| ], | ||
| "continuationToken": None, |
There was a problem hiding this comment.
I seem to remember at the end tc doesn't return a continuationToken at all? (worth double checking)
There was a problem hiding this comment.
Yep, we don't need it. sorry about that. https://github.com/taskcluster/taskcluster/blob/beb8e078536efc49aada91bd1e5b2973aad7b20d/clients/client-go/tcqueue/tcqueue.go#L297
There was a problem hiding this comment.
nit: the server side is https://github.com/taskcluster/taskcluster/blob/beb8e078536efc49aada91bd1e5b2973aad7b20d/services/queue/src/api.js#L403 rather than the go client implementation
abhishekmadan30
force-pushed
the
add-page
branch
from
c1b4349 to
974d7c2
Compare
abhishekmadan30
force-pushed
the
add-page
branch
from
974d7c2 to
b03b9a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.