Add subpath imports to @tabler/icons-react-native
#1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tranhl
commented
Jun 6, 2025
| format: 'cjs', | ||
| inputs, | ||
| extension: 'cjs', | ||
| preserveModules: true, |
There was a problem hiding this comment.
This was required to emit JS for each individual icon. Prior to this change, JS was only emitted for the entire bundle.
tranhl
commented
Jun 6, 2025
| "strict": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "module": "ESNext", | ||
| "moduleResolution": "Bundler", |
There was a problem hiding this comment.
I had to update the module resolution to Bundler in order to get TS working. The test-react project has the same issue, might be something to look into.
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
@codecalm Is there any appetite for getting this PR landed? Let me know if there's anything I can do from my side to move things along 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds subpath imports to
@tabler/icons-react-native, allowing devs to import the icons they need without importing all Tabler icons:I took the liberty of creating a test project for the package to verify that the changes worked as well. The implementation isn't ideal as I'm using a copy of the Vite project from
test-react, but it should suffice since subpath imports don't require tree shaking to reduce bundle size.Fixes #1229