A few changes to make it easier to build on macOS or to build C++ programs #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3d
commented
Aug 7, 2023
c3d
commented
- Change the checksum computation to use tools available on macOS
- Fix missing _exit symbol (called from abort())
- Add C++ wrappers around dmcp.h to make it possible to include in C++ programs.
The two utilities use different ways to get the size of a file, both of which don't work on macOS. Replace them with `cat <file> | wc -c`. Signed-off-by: Christophe de Dinechin <christophe@dinechin.org>
This is required when `abort()` is linked in, otherwise we get an unsatisfied symbol. Signed-off-by: Christophe de Dinechin <christophe@dinechin.org>
Signed-off-by: Christophe de Dinechin <christophe@dinechin.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.