[PoC][Concurrency] Typed throws in Task.init and .detached #74110
+243
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
|
@swift-ci please smoke test |
ktoso
commented
Jun 4, 2024
ktoso
commented
Jun 4, 2024
| } | ||
|
|
||
| // ==== Typed throws Task.init overloads --------------------------------------- | ||
|
|
There was a problem hiding this comment.
If we decide we want to do this, I'd see if i can DRY this up in any way.
ktoso
added
concurrency
|
ktoso
force-pushed
the
wip-taskinit-typed-throws
branch
from
605843a to
f7d93ff
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-taskinit-typed-throws
branch
from
f7d93ff to
ef7bb79
Compare
|
@swift-ci please smoke test |
|
Replaced by #84802 thanks to gyb-generating initializers now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC of adding typed throws to just Task.init and Task.detached -- we can't do it yet with TaskGroup but it would be perhaps worth doing so where we can, i.e. task initializers.
A bit confused about the ABI of
.value-- I'm expecting that to need a new ABI entry point but that does not seem to be the case? Adding the typed throw to the accessor does not seem to change the mangling -- see second commit: adding an abi compat function just ends up in duplicate symbols as well -- is this a bug in typed throws mangling?rdar://129195968
SE proposal: swiftlang/swift-evolution#2990