-
Notifications
You must be signed in to change notification settings - Fork 488
Expose query builder options to .from method #1570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Expose query builder options to .from method #1570
Conversation
Hi @stenlan ! Thank you very much for your contribution. Can you please import your changes from this PR here, and make the changes needed in the new monorepo? I will be archiving the old repos soon. You will still be able to view the PR content, don't worry. I understand that this may be frustrating, but thank you very much for your time and contribution! |
14bc550
to
59a5899
Compare
Thank you @mandarini for the response. I have integrated the changes into the new monorepo structure to the best of my ability, but because of time constraints I have not yet been able to successfully set up the monorepo locally. For some reason, in |
"@supabase/postgrest-js": "*", | ||
"@supabase/realtime-js": "*", | ||
"@supabase/storage-js": "*", | ||
"@supabase/node-fetch": "2.6.15" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert changes to package.json
"@supabase/auth-js": "*", | ||
"@supabase/functions-js": "*", | ||
"@supabase/node-fetch": "2.6.15", | ||
"@supabase/postgrest-js": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please revert this change
@stenlan thank you for your contribution! Nothing special is needed to set up your local environment. Did you go through our contributing guide? Just clone the repo, run |
What kind of change does this PR introduce?
Introduces a way to pass options to the PostgrestQueryBuilder instance on a per-request basis.
What is the current behavior?
There is no way to specify per-request options currently.
#438
What is the new behavior?
An optional parameter is introduced that can be passed to the
.from
method, where users can optionally specify customfetch
andheaders
options.Additional context
This is a supporting PR for supabase/postgrest-js#648 that updates the method signature in the @supabase/supabase-js package.