Skip to content

Conversation

rajanarahul93
Copy link
Contributor

Resolves #8213.

Description

What is the purpose of this pull request?

This pull request:

  • fixes two separate linting errors: a no-redeclare error in @stdlib/bench/harness by renaming a variable to avoid shadowing a global, and several no-new-array errors in @stdlib/stats/pcorrtest by refactoring array creation to use literals and .push().

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Oct 7, 2025
@stdlib-bot
Copy link
Contributor

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
bench/harness $\color{green}513/513$
$\color{green}+100.00\%$
$\color{green}60/60$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}513/513$
$\color{green}+100.00\%$
stats/pcorrtest $\color{green}519/519$
$\color{green}+100.00\%$
$\color{green}83/83$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}519/519$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
2 participants