Skip to content

feat: retry x times if unable to find pom data #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: retry x times if unable to find pom data #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions finder/finder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"
"log"
"sync"
"time"

"github.com/status-im/go-maven-resolver/fetcher"
"github.com/status-im/go-maven-resolver/pom"
Expand Down Expand Up @@ -43,6 +44,10 @@ func (f *Finder) ResolveDep(dep pom.Dependency) (string, *pom.Project, error) {
result := make(chan *fetcher.Result)
defer close(result)

// Add constants for retry logic
const maxRetries = 3
const retryDelay = time.Second * 1

if !dep.HasVersion() {
path := dep.GetMetaPath()
/* We use workers for HTTP request to avoid running out of sockets */
Expand All @@ -63,12 +68,24 @@ func (f *Finder) ResolveDep(dep pom.Dependency) (string, *pom.Project, error) {

path := dep.GetPOMPath()
/* We use workers for HTTP request to avoid running out of sockets */
f.fetchers.Queue <- fetcher.NewJob(result, path, repo)
rval = <-result
// Retry logic for fetching data
for attempt := 0; attempt < maxRetries; attempt++ {
f.fetchers.Queue <- fetcher.NewJob(result, path, repo)
rval = <-result

if rval.Data != nil {
break
}

if attempt < maxRetries-1 {
time.Sleep(retryDelay)
}
}

if rval.Data == nil {
return "", nil, errors.New("no pom data")
}

project, err := pom.ProjectFromReader(rval.Data)
if err != nil {
return "", nil, err
Expand Down