-
Notifications
You must be signed in to change notification settings - Fork 131
avoid telemetry failing interfering with mcp responses #2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d7214b8
to
a23c79f
Compare
@danbarr i came with the cleanest approach. The error happens in the same lines (write header) but i added some error controls there to avoid that telemetry crashes the server. I think it's cleaner. Please try |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2147 +/- ##
==========================================
- Coverage 48.90% 48.85% -0.05%
==========================================
Files 242 242
Lines 30722 30741 +19
==========================================
- Hits 15024 15018 -6
- Misses 14573 14591 +18
- Partials 1125 1132 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a23c79f
to
d78c0a4
Compare
Server was crashing with 404 errors when writing to telemetry. So add some control of panic error on the calls to telemetry, to tolerate failures but don't make them fatal. Also implement the flush method, that is essential for sse/streaming Closes: #2114
d78c0a4
to
9e05fc7
Compare
Server was crashing with 404 errors when writing to telemetry
Closes: #2114