Skip to content

fix: skip linter and tests in create PR script #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2025
+21 −13
Merged

fix: skip linter and tests in create PR script #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d3459e
fix: skip linter and tests in create PR script
marceljk Oct 10, 2025
a87b6e1
Add step to remove waiters
marceljk Oct 13, 2025
29ae4cb
remove leftover from testing
marceljk Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ jobs:
uses: actions/setup-go@v5
with:
go-version: ${{ env.GO_VERSION_BUILD }}
- name: Remove waiters
working-directory: ./sdk-repo-updated
run: rm -r services/*/wait
- name: Lint
working-directory: ./sdk-repo-updated
run: make lint skip-non-generated-files=true
Expand Down
31 changes: 18 additions & 13 deletions scripts/sdk-create-pr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,22 +98,27 @@ for service_path in ${work_dir}/sdk_to_push/services/*; do
go work use -r .
fi

# If lint or test fails for a service, we skip it and continue to the next one
make lint skip-non-generated-files=true service="$service" || {
echo "! Linting failed for $service. THE UPDATE OF THIS SERVICE WILL BE SKIPPED."
continue
}
# Our unit test template fails because it doesn't support fields with validations,
# such as the UUID component used by IaaS. We introduce this hardcoded skip until we fix it
if [ "${service}" = "iaas" ] || [ "${service}" = "iaasalpha" ]; then
echo ">> Skipping tests of $service service"
else
make test skip-non-generated-files=true service="$service" || {
echo "! Testing failed for $service. THE UPDATE OF THIS SERVICE WILL BE SKIPPED."
# If the target branch is main, we run the linter and tests in order to have code which can be compiled.
# If the target branch is not main, we skip the linter and tests, because in the create PRs the CI pipeline will check run them as well.
# This prevents unrecognized api changes, because we will see them within the PR itself.
if [[ "$branch" == "main" ]]; then
# If lint or test fails for a service, we skip it and continue to the next one
make lint skip-non-generated-files=true service="$service" || {
echo "! Linting failed for $service. THE UPDATE OF THIS SERVICE WILL BE SKIPPED."
continue
}
# Our unit test template fails because it doesn't support fields with validations,
# such as the UUID component used by IaaS. We introduce this hardcoded skip until we fix it
if [ "${service}" = "iaas" ] || [ "${service}" = "iaasalpha" ]; then
echo ">> Skipping tests of $service service"
else
make test skip-non-generated-files=true service="$service" || {
echo "! Testing failed for $service. THE UPDATE OF THIS SERVICE WILL BE SKIPPED."
continue
}
fi
fi

git add "services/${service}/"
if [ "${LANGUAGE}" == "go" ] && [ ! -d "${work_dir}/sdk_backup/services/${service}/" ]; then # Check if it is a newly added SDK module
git add go.work
Expand Down
Loading