Skip to content

Conversation

Fyusel
Copy link
Contributor

@Fyusel Fyusel commented Sep 4, 2025

No description provided.

@Fyusel Fyusel requested a review from a team as a code owner September 4, 2025 09:11
Signed-off-by: Alexander Dahmen <alexander.dahmen@inovex.de>
@rubenhoenle rubenhoenle force-pushed the keep-java-wait-handlers-during-creation branch from ab16b94 to 6ea313f Compare September 5, 2025 12:37
rm -r "${SERVICES_FOLDER}/${service}/.openapi-generator/"

# If the service has a wait package, move them inside the service folder
if [ -d ${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ -d ${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait ]; then
if [ -d "${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait" ]; then

It's best practice to quote such things in bash 😅

# If the service has a wait package, move them inside the service folder
if [ -d ${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait ]; then
echo "Found ${service} \"wait\" package"
cp -r ${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait ${SERVICES_FOLDER}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cp -r ${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait ${SERVICES_FOLDER}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait
cp -r "${sdk_services_backup_dir}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait" "${SERVICES_FOLDER}/${service}/src/main/java/cloud/stackit/sdk/${service}/wait"

same here

Copy link

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale label Sep 16, 2025
@marceljk marceljk removed the Stale label Sep 16, 2025
Copy link

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

Copy link

github-actions bot commented Oct 3, 2025

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale label Oct 3, 2025
@marceljk marceljk removed the Stale label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants