feat: Add support for URLs with query parameters in MimeTypeDetector #4616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for detecting MIME types from URLs that contain query parameters.
Changes
Implementation fix:
getMimeType(URI uri)
to useuri.getPath()
instead ofuri.toString()
https://example.com/image.png?version=1.2
correctly detect asimage/png
Test coverage:
Rationale
Previously, URLs with query parameters (e.g., image.jpg?version=1.2) would fail because the query string was included in MIME type detection. By using getPath() instead of toString(), we now strip query parameters and correctly detect the file extension.