Skip to content

Add FileClasspathEntry validation #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add FileClasspathEntry validation #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...s/src/main/java/org/springframework/experimental/boot/server/exec/FileClasspathEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2023 the original author or authors.
* Copyright 2012-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -24,8 +24,13 @@ public class FileClasspathEntry implements ClasspathEntry {

private final File file;

public FileClasspathEntry(String file) {
this(new File(file));
public FileClasspathEntry(String filePath) {
File file = new File(filePath);
if (!file.isDirectory() && !file.getName().toLowerCase().endsWith("jar")) {
String absolutePath = file.getAbsolutePath();
throw new IllegalArgumentException("File must be a jar file or directory '" + absolutePath + "'");
}
this.file = file;
}

public FileClasspathEntry(File file) {
Expand Down
8 changes: 8 additions & 0 deletions .../test/java/org/springframework/experimental/boot/server/exec/FileClasspathEntryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import org.junit.jupiter.api.Test;

import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
import static org.assertj.core.api.Assertions.assertThatIllegalStateException;

class FileClasspathEntryTests {
Expand All @@ -32,4 +33,11 @@ void resolveWhenDoesNotExist() {
.withMessageContaining("Could not find file to add to the classpath");
}

@Test
void constructorWhenNotJarOrDirectoryThrowsIllegalArgumentException() {
String invalidPath = "some-file.txt";
assertThatIllegalArgumentException().isThrownBy(() -> new FileClasspathEntry(invalidPath))
.withMessageContaining("File must be a jar file or directory");
}

}