fix: make v-click
work with LightOrDark by wrapping slots in a div
#2291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
v-click
directive did not work on theLightOrDark
component. Wrapping the slots in aLightOrDark
ensuresv-click
attaches to a real DOM element.In fact, we could simply write
to achieve the same effect, so I’m not sure if this change is meaningful enough. However, it does make usage involving LightOrDark a bit more concise.
Fixes #2271