Skip to content

Conversation

weriomat
Copy link
Contributor

@weriomat weriomat commented Jun 9, 2025

this should fix #318 by deduplicating the flake paths with a Hashset

this should fix [serokell#318](serokell#318)
by deduplicating the flake paths with a Hashset
Copy link

@Sntx626 Sntx626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not de-duplicate all flake checks, just flake checks from having the same node provided multiple times...

What is the use-case for this?

@weriomat
Copy link
Contributor Author

weriomat commented Oct 1, 2025

Currently, if I deploy multiple nodes from a single repo (i.e. deploy --targets .#a .#b) it should run nix flake check . for each node/ path for the node. Thus, it should be run two times, my attempt is to deduplicate by the path such as it will only get run once regardless of the amount of nodes deployed from that repo.
That is my understanding of the issue described in #318.
Have I missed something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checks are repeated several times
2 participants