Skip to content

Added two new methods to hook all things okhttp #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added two new methods to hook all things okhttp #676

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03928c9
Added two new methods to hook all things okhttp
StingraySA May 10, 2024
b245d79
Forgot to actually call the new function
StingraySA May 10, 2024
0cbb307
Merge branch 'sensepost:master' into patch-1
StingraySA Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions agent/src/android/pinning.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,56 @@ const okHttp3CertificatePinnerCheckOkHttp = (ident: string): any | undefined =>
});
};

const okHttp3CertificatePinnerExpanded = (ident: string): any | undefined => {
return wrapJavaPerform(() => {
try {
const certificatePinner: CertificatePinner = Java.use("okhttp3.CertificatePinner");
send(c.blackBright(`Found okhttp3.CertificatePinner, overriding CertificatePinner.check$okhttp()`));

try {
const CertificatePinnerCheckOkHttp = certificatePinner.check$okhttp.overload('java.lang.String', 'java.security.cert.Certificate');

// tslint:disable-next-line:only-arrow-functions
CertificatePinnerCheckOkHttp.implementation = function (str,cert) {
qsend(quiet,
c.blackBright(`[${ident}] `) + `Called check$okhttp ` +
c.green(`OkHTTP 3.x CertificatePinner.check$okhttp() - `) +
str,
} catch(err) {
qsend(quiet,
c.blackBright(`[${ident}] `) +
c.red(`Skipping Expanded OkHTTP Hook`),
}

try {
const CertificatePinnerCheckOkHttp = certificatePinner.check$okhttp.overload('java.lang.String', '[Ljava.security.cert.Certificate;');

// tslint:disable-next-line:only-arrow-functions
CertificatePinnerCheckOkHttp.implementation = function (str,cert_array) {
qsend(quiet,
c.blackBright(`[${ident}] `) + `Called check$okhttp ` +
c.green(`OkHTTP 3.x CertificatePinner.check$okhttp() - `) +
str,
} catch(err) {
qsend(quiet,
c.blackBright(`[${ident}] `) +
c.red(`Skipping Expanded OkHTTP Hook`),
}

);
};

return CertificatePinnerCheckOkHttp;

} catch (err) {
if ((err as Error).message.indexOf("ClassNotFoundException") === 0) {
throw err;
}
}
});
};


const appceleratorTitaniumPinningTrustManager = (ident: string): any | undefined => {
return wrapJavaPerform(() => {
try {
Expand Down Expand Up @@ -325,6 +375,7 @@ export const disable = (q: boolean): void => {
job.implementations.push(sslContextEmptyTrustManager(job.identifier));
job.implementations.push(okHttp3CertificatePinnerCheck(job.identifier));
job.implementations.push(okHttp3CertificatePinnerCheckOkHttp(job.identifier));
job.implementations.push(okHttp3CertificatePinnerExpanded(job.identifier));
job.implementations.push(appceleratorTitaniumPinningTrustManager(job.identifier));
job.implementations.push(trustManagerImplVerifyChainCheck(job.identifier));
job.implementations.push(trustManagerImplCheckTrustedRecursiveCheck(job.identifier));
Expand Down