Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,12 @@ jobs:
distcheck:
runs-on: ubuntu-latest
permissions:
contents: write # TODO: This is needed for release, maybe split the release steps to a different job?
# Permissions from https://github.com/googleapis/release-please-action?tab=readme-ov-file#basic-configuration
# TODO: This is only needed for release, maybe split the release steps to a different job?
contents: write
pull-requests: write
# Needed for adding labels for PRs, we shouldn't actually need this, see https://github.com/orgs/community/discussions/156181
issues: write
Comment on lines +50 to +51
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the situation may change in the future (by correcting either the documentation or the behavior)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

strategy:
matrix:
include:
Expand Down