Skip to content

Conversation

orlitzky
Copy link
Contributor

@orlitzky orlitzky commented Oct 8, 2025

A coercion test for BooleanPolynomialRing requires polybori/brial. We already have a "feature" for this; it's just missing the "needs" bit.

A coercion test for BooleanPolynomialRing requires polybori/brial. We
already have a "feature" for this; it's just missing the "needs" bit.
@orlitzky
Copy link
Contributor Author

orlitzky commented Oct 8, 2025

Brial is standard in the sage distribution, but optional for sagelib itself. If you really want to test with it disabled, you can meson setup -Dbrial=disabled ...

Copy link

github-actions bot commented Oct 8, 2025

Documentation preview for this PR (built with commit 1f3596e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@orlitzky
Copy link
Contributor Author

orlitzky commented Oct 8, 2025

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 11, 2025
sagemathgh-41006: sage.rings.polynomial.multi_polynomial_libsingular: add one "needs"
    
A coercion test for `BooleanPolynomialRing` requires polybori/brial. We
already have a "feature" for this; it's just missing the "needs" bit.
    
URL: sagemath#41006
Reported by: Michael Orlitzky
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 12, 2025
sagemathgh-41006: sage.rings.polynomial.multi_polynomial_libsingular: add one "needs"
    
A coercion test for `BooleanPolynomialRing` requires polybori/brial. We
already have a "feature" for this; it's just missing the "needs" bit.
    
URL: sagemath#41006
Reported by: Michael Orlitzky
Reviewer(s): Frédéric Chapoton
@vbraun vbraun merged commit 15e671c into sagemath:develop Oct 16, 2025
18 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants