Skip to content

some ErrorGuaranteed cleanups #147670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

some ErrorGuaranteed cleanups #147670

wants to merge 1 commit into from
+16 −37

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Oct 14, 2025

If we've got an ErrorGuaranteed, use it.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 14, 2025

r? @spastorino

rustbot has assigned @spastorino.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@BoxyUwU
Copy link
Member

BoxyUwU commented Oct 15, 2025

@bors r+ rollup

@BoxyUwU
Copy link
Member

BoxyUwU commented Oct 15, 2025

r? BoxyUwU

@bors
Copy link
Collaborator

bors commented Oct 15, 2025

📌 Commit 4dfbf11 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2025
@rustbot rustbot assigned BoxyUwU and unassigned spastorino Oct 15, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 15, 2025
@matthiaskrgr
Rollup merge of rust-lang#147670 - lcnr:no-ok-ret-guar, r=BoxyUwU
a7d71ed 
some `ErrorGuaranteed` cleanups

If we've got an `ErrorGuaranteed`, use it.
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 15, 2025
Open
bors added a commit that referenced this pull request Oct 15, 2025
@bors
Auto merge of #147720 - matthiaskrgr:rollup-rpq38qg, r=matthiaskrgr
27f78a0 
Rollup of 5 pull requests

Successful merges:

 - #143191 (Stabilize `rwlock_downgrade` library feature)
 - #147000 (std: Add Motor OS std library port)
 - #147670 (some `ErrorGuaranteed` cleanups)
 - #147716 (Fix some comments)
 - #147718 (miri: use allocator_shim_contents codegen helper)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BoxyUwU BoxyUwU

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lcnr @rustbot @BoxyUwU @bors @spastorino