Fix ICE when late-bound lifetimes don't appear in fn signature #147631
+113
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR rust-lang#135479 changed how late-bound regions are registered for MIR borrowck, switching from `for_each_late_bound_region_in_item` to iterating over `bound_inputs_and_output.bound_vars()`. However, for regular functions, the latter only includes late-bound lifetimes that appear in the function's inputs or output, missing unused lifetime parameters. This caused an ICE when `replace_bound_regions_with_nll_infer_vars` tried to look up these unregistered regions. This ensures all late-bound regions are properly registered in the universal regions map before they're needed during region substitution.
|
This PR changes a file inside |
rustbot
added
S-waiting-on-review
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
|
|
r? types |
rustbot
added
the
T-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #135479 changed how late-bound regions are registered for MIR borrowck, switching from
for_each_late_bound_region_in_itemto iterating overbound_inputs_and_output.bound_vars(). However, for regular functions, the latter only includes late-bound lifetimes that appear in the function's inputs or output, missing unused lifetime parameters.This caused an ICE when
replace_bound_regions_with_nll_infer_varstried to look up these unregistered regions.This ensures all late-bound regions are properly registered in the universal regions map before they're needed during region substitution.
Fixes #135845