-
Notifications
You must be signed in to change notification settings - Fork 13.8k
librustdoc: Make RenderOptions boolean fields into newtypes #147621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @notriddle rustbot has assigned @notriddle. Use |
This comment has been minimized.
This comment has been minimized.
f39b8ba
to
89721a9
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
pub(crate) generate_macro_expansion: bool, | ||
pub(crate) generate_macro_expansion: GenerateMacroExpansion, | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please turn all of them into enum { Yes, No }
, that's what's more conventional in this repo (and also what Esteban suggested back then (see the PR linked from the issue)).
r? @fmease |
|
@rustbot author |
Reminder, once the PR becomes ready for a review, use |
closes #87752