Skip to content

fix: support break with value in completions #20673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

fix: support break with value in completions #20673

merged 1 commit into from
Oct 14, 2025
+72 −25

Conversation

A4-Tacks
Copy link
Contributor

@A4-Tacks A4-Tacks commented Sep 16, 2025 •
edited by rustbot
Loading

Close #19817

fn foo() -> i32 {
    loop {
        $0
    }
}

Before this PR:

fn foo() -> i32 {
    loop {
        break;
    }
}

After this PR:

fn foo() -> i32 {
    loop {
        break $0;
    }
}

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2025
ShoyuVanilla
ShoyuVanilla reviewed Oct 14, 2025
View reviewed changes
@A4-Tacks
Add break value completion support
9eb11f9 
```rust
fn foo() -> i32 {
    loop {
        $0
    }
}
```

**Before this PR**:

```rust
fn foo() -> i32 {
    loop {
        break;
    }
}
```

**After this PR**:

```rust
fn foo() -> i32 {
    loop {
        break $0;
    }
}
```
@A4-Tacks A4-Tacks requested a review from ShoyuVanilla October 14, 2025 08:52
ShoyuVanilla
ShoyuVanilla approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Oct 14, 2025
Merged via the queue into rust-lang:master with commit 5e74dc1 Oct 14, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2025
@A4-Tacks A4-Tacks deleted the break-value branch October 14, 2025 09:23
@lnicola lnicola changed the title Add break value completion support fix: support break with value in completions Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Completion break value in loop

3 participants

@A4-Tacks @ShoyuVanilla @rustbot