Remove wildcard re-exports #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK modulo CI |
|
Looks like CI is red because of formatting. |
tcharding
force-pushed
the
03-19-rm-wildcard
branch
from
8384783 to
863fd96
Compare
|
Ran the formatter, no other changes. |
|
Ah, sanitizers again :) |
|
EDIT: I just did #687 |
tcharding
force-pushed
the
03-19-rm-wildcard
branch
from
863fd96 to
9e1ec1a
Compare
|
No acks so rebasing to get up to date with master branch. |
|
So, in #656 we added a "check for changes to the public API" script but it looks like we have failed to CI-enforce this. Therefore this PR is unnecessarily hard to check. I think, for one, that you are losing a reexport of Can you open a PR to run the API script (there are a bunch of changes even on master) and to CI-check this, then rebase this PR on that? |
|
Yep sure thing. |
The `just` command makes scripts and commands discoverable for new devs and old devs alike when switching between repos. Add a justfile copied from bitcoin with changes as required.
Add a command to run the `contrib/check-for-api-changes.sh` script.
Run `just check-api` and commit the changes. We should have never gotten to this state, upcoming patch will check for changes in CI.
Add a job to run the `contrib/check-for-api-changes.sh` script in CI.
Copy the script from `rust-bitcoin`, also add a `just` command to call it.
tcharding
force-pushed
the
03-19-rm-wildcard
branch
from
9e1ec1a to
1dc5bd2
Compare
|
Now on top of #691 |
Wildcards make it hard to grep for where stuff comes from, explicit imports and re-exports are ... more explicit. Import and re-export explicitly instead of by using wildcards.
Wildcards make it hard to grep for where stuff comes from, explicit imports and re-exports are ... more explicit. Re-export the `key` types explicitly.
tcharding
force-pushed
the
03-19-rm-wildcard
branch
from
1dc5bd2 to
0da394e
Compare
|
Awesome :). So much easier to review. I'm gonna try to ACK/merge this even though both Github and my local tools see it as 7 independent commits (even though 5 are already in master). I verified that the first 5 are exactly the same commits in #691. |
apoelstra
previously approved these changes
Mar 27, 2024
tcharding
dismissed
apoelstra’s stale review
The merge-base changed after approval.
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
0da394e64848baf93c0aca0a9d6b5c9b2648b908 Remove wildcard re-exports of key types (Tobin C. Harding)
d63e95b99b5183aa181a82eee89727f290a6c82d Remove wildcard re-exports of context types (Tobin C. Harding)
Pull request description:
Wildcards make it hard to grep for where stuff comes from, explicit imports and re-exports are ... more explicit.
- Patch 1: Re-export the `context` types explicitly.
- Patch 2: Re-export the `key` types explicitly.
Fix: #681
ACKs for top commit:
apoelstra:
ACK 0da394e64848baf93c0aca0a9d6b5c9b2648b908
Tree-SHA512: ac92baa9b9abaaff436223bf1d18d286825dbfc8eef401c714314902ff471db4830dce360138845efd781bcb883676d0cbc3db8d691476403eb487a0585edeaa
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
0da394e64848baf93c0aca0a9d6b5c9b2648b908 Remove wildcard re-exports of key types (Tobin C. Harding)
d63e95b99b5183aa181a82eee89727f290a6c82d Remove wildcard re-exports of context types (Tobin C. Harding)
Pull request description:
Wildcards make it hard to grep for where stuff comes from, explicit imports and re-exports are ... more explicit.
- Patch 1: Re-export the `context` types explicitly.
- Patch 2: Re-export the `key` types explicitly.
Fix: #681
ACKs for top commit:
apoelstra:
ACK 0da394e64848baf93c0aca0a9d6b5c9b2648b908
Tree-SHA512: ac92baa9b9abaaff436223bf1d18d286825dbfc8eef401c714314902ff471db4830dce360138845efd781bcb883676d0cbc3db8d691476403eb487a0585edeaa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wildcards make it hard to grep for where stuff comes from, explicit imports and re-exports are ... more explicit.
contexttypes explicitly.keytypes explicitly.Fix: #681