Remove deprecated entries from setup.cfg

[cjmayo]

License classifiers are deprecated in favor of SPDX license expressions.

With Python 2.7 end-of-life, support for building universal wheels is being removed.

[gemini-code-assist]

Summary of Changes

Hello @cjmayo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the setup.cfg configuration by removing outdated entries. It updates the license classification to align with modern standards that favor SPDX license expressions and removes the configuration for building universal wheels, a feature no longer supported following the end-of-life of Python 2.7. These changes ensure the project's packaging metadata is current and efficient.

Highlights

• License Classifier Update: Removed the deprecated "License :: OSI Approved :: MIT License" classifier from setup.cfg as SPDX license expressions are now the preferred method for specifying licenses.
• Universal Wheel Build Removal: Eliminated the [bdist_wheel] section and its universal = 1 setting from setup.cfg. This change reflects the removal of support for building universal wheels, which is a consequence of Python 2.7 reaching its end-of-life.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes deprecated entries from setup.cfg. The removal of the License :: OSI Approved :: MIT License classifier is appropriate as it's superseded by the license = MIT SPDX identifier. Similarly, removing the [bdist_wheel] section with universal = 1 is correct given that Python 2 support is no longer necessary. These changes are good housekeeping and align the project with current Python packaging standards.

[thijstriemstra]

Are there any tools that throw a warning because of these deprecated lines? if not, i dont see why we would remove it.

[cjmayo]

Yes:

luma_core-2.5.1 $ python -m build
* Creating isolated environment: venv+pip...
* Installing packages in isolated environment:
  - setuptools >= 40.6.0
  - wheel
* Getting build dependencies for sdist...
/lib/python3.13/site-packages/setuptools/dist.py:759: SetuptoolsDeprecationWarning: License classifiers are deprecated.
!!

        ********************************************************************************
        Please consider removing the following classifiers in favor of a SPDX license expression:

        License :: OSI Approved :: MIT License

        See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
        ********************************************************************************

!!
...
running bdist_wheel
/lib/python3.13/site-packages/setuptools/_distutils/cmd.py:135: SetuptoolsDeprecationWarning: bdist_wheel.universal is deprecated
!!

        ********************************************************************************
        With Python 2.7 end-of-life, support for building universal wheels
        (i.e., wheels that support both Python 2 and Python 3)
        is being obviated.
        Please discontinue using this option, or if you still need it,
        file an issue with pypa/setuptools describing your use case.

        By 2025-Aug-30, you need to update your project and remove deprecated calls
        or your builds will no longer be supported.
        ********************************************************************************

!!
  self.finalize_options()