Skip to content

fix(): fixing memory leak in keys-source-task #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2025
Merged

fix(): fixing memory leak in keys-source-task #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions ...redis-kafka-connect/src/main/java/com/redis/kafka/connect/source/RedisKeysSourceTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,6 @@ public class RedisKeysSourceTask extends SourceTask {

public static final Schema KEY_SCHEMA = Schema.STRING_SCHEMA;

/**
* The offsets that have been processed and that are to be acknowledged by the
* reader in {@link RedisKeysSourceTask#commit()}.
*/
private final List<Map<String, ?>> sourceOffsets = new ArrayList<>();
private final ToStructFunction converter = new ToStructFunction();
private final Clock clock;

Expand Down Expand Up @@ -96,17 +91,10 @@ public void start(Map<String, String> props) {
}
}

private void addSourceOffset(Map<String, ?> sourceOffset) {
sourceOffsets.add(sourceOffset);
}

@Deprecated
@Override
public void commitRecord(SourceRecord sourceRecord) throws InterruptedException {
Map<String, ?> currentOffset = sourceRecord.sourceOffset();
if (currentOffset != null) {
addSourceOffset(currentOffset);
}
// do nothing - offset tracking not needed for Redis key monitoring
}

@Override
Expand Down