-
-
Notifications
You must be signed in to change notification settings - Fork 155
Feat/elkjs web worker #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for reaflow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate the contribution!
For some reason I thought ELK already ran in a webworker.
I noticed you upgraded the npm package, was there any other updates I should mention in the release notes that could be impacted?
Unfortunately it's not using web workers by default, but this change will help a lot especially working with data so the it won't freeze the main thread. I did the upgrade on my project as well a while ago, no breaking changes I experienced. I have to note that thought I've only tested this change on the reaflow storybook. Also I added "layered" to algorithms option for the web worker. If the library is using other algorithms it should be updated accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
# use web worker to not block main thread: reaviz/reaflow#275
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
It will use web worker for elkjs when available. Also use the existing elkjs instance.
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Uses elkjs web worker.
Does this PR introduce a breaking change?
Other information