-
Notifications
You must be signed in to change notification settings - Fork 292
Investigate use of composition API for wiring veevalidate as form validation #15521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Investigate use of composition API for wiring veevalidate as form validation #15521
Conversation
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
2573882
to
5dbc231
Compare
@rak-phillip irony wants that the failing tests on a11y is for user retention 😅 |
I don't see the irony, the work represented here was from an earlier POC and is just that, a concept.. I'll investigate the failures to see what the problem might be. I can also work on cleaning up the code to be something more production ready. |
Sounds fair. |
There's two reasons why the unit tests are failing:
I'm actively working on updating the implementation - I should have more time tomorrow to dive into it some more. |
Oh that's a magnificent news as your usual 🥂 |
Summary
Fixes #15366
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist