Skip to content

Conversation

cnotv
Copy link
Member

@cnotv cnotv commented Sep 25, 2025

Summary

Fixes #15366

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

rak-phillip and others added 4 commits September 22, 2025 16:13
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@cnotv cnotv force-pushed the feature/15366-validation-composition-api-custom-component branch from 2573882 to 5dbc231 Compare September 26, 2025 18:59
@cnotv cnotv requested a review from rak-phillip September 26, 2025 19:05
@cnotv
Copy link
Member Author

cnotv commented Sep 26, 2025

@rak-phillip irony wants that the failing tests on a11y is for user retention 😅
Cypress instance: ded9eff1-635c-45bf-92c7-75b8f436451b/test/r53

@rak-phillip
Copy link
Member

@rak-phillip irony wants that the failing tests on a11y is for user retention 😅 Cypress instance: ded9eff1-635c-45bf-92c7-75b8f436451b/test/r53

I don't see the irony, the work represented here was from an earlier POC and is just that, a concept.. I'll investigate the failures to see what the problem might be. I can also work on cleaning up the code to be something more production ready.

@cnotv
Copy link
Member Author

cnotv commented Sep 29, 2025

@rak-phillip irony wants that the failing tests on a11y is for user retention 😅 Cypress instance: ded9eff1-635c-45bf-92c7-75b8f436451b/test/r53

I don't see the irony, the work represented here was from an earlier POC and is just that, a concept.. I'll investigate the failures to see what the problem might be. I can also work on cleaning up the code to be something more production ready.

Sounds fair.
I am trying to debug the issue in Jest.

@rak-phillip
Copy link
Member

rak-phillip commented Sep 30, 2025

There's two reasons why the unit tests are failing:

  1. There are issues with vee-validate imports when running jest. It looks like we can resolve the problem with the following patch:

    diff --git a/jest.config.js b/jest.config.js
    index 92cf49fc8a..3df5621a72 100644
    --- a/jest.config.js
    +++ b/jest.config.js
    @@ -38,11 +38,15 @@ module.exports = {
       // Babel
       transform: {
         '^.+\\.js$':   '<rootDir>/node_modules/babel-jest', // process js with `babel-jest`
    +    '^.+\\.mjs$':  '<rootDir>/node_modules/babel-jest', // process mjs with `babel-jest`
         '.*\\.(vue)$': '<rootDir>/node_modules/@vue/vue3-jest', // process `*.vue` files with `vue-jest`
         '^.+\\.vue$':  './vue3JestRegisterTs.js', // point to a  different transformer than vue-jest and call registerTs before exporting vue-jest
         '^.+\\.tsx?$': 'ts-jest', // process `*.ts` files with `ts-jest`
         '^.+\\.svg$':  '<rootDir>/svgTransform.js' // to mock `*.svg` files
       },
    +  transformIgnorePatterns: [
    +    '<rootDir>/node_modules/(?!.*vee-validate.*)',
    +  ],
       snapshotSerializers: ['<rootDir>/node_modules/jest-serializer-vue'],
  2. Reactivity is broken for inputs that don't utilize form validation. This is where a bulk of other failures will arise throughout dashboard.

I'm actively working on updating the implementation - I should have more time tomorrow to dive into it some more.

@cnotv
Copy link
Member Author

cnotv commented Sep 30, 2025

Oh that's a magnificent news as your usual 🥂
I was working around that but I did not manage to figure out the right configuration.
Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate use of composition API for wiring veevalidate as form validation

2 participants