Skip to content

Fix PHP 8.4: Implicitly nullable parameter declarations deprecated #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix PHP 8.4: Implicitly nullable parameter declarations deprecated #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e05a343
Update Helper.php
jurisvaldovskis Jan 25, 2025
6e2ea02
Update Attribute.php
jurisvaldovskis Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Attribute.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ public function getKeyIndexes(): array
* @param string|null $key
* @return mixed
*/
public function getValue(string $key = null)
public function getValue(?string $key = null)
{
if ($key && $this->isArrayAttribute()) {
$key = $this->resolveSiblingKey($key);
Expand Down
4 changes: 2 additions & 2 deletions src/Helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ public static function snakeCase(string $value, string $delimiter = '_'): string
* @param string|null $lastSeparator
* @return string
*/
public static function join(array $pieces, string $separator, string $lastSeparator = null): string
public static function join(array $pieces, string $separator, ?string $lastSeparator = null): string
{
if (is_null($lastSeparator)) {
$lastSeparator = $separator;
Expand All @@ -245,7 +245,7 @@ public static function join(array $pieces, string $separator, string $lastSepara
* @param string|null $suffix
* @return array
*/
public static function wraps(array $strings, string $prefix, string $suffix = null): array
public static function wraps(array $strings, string $prefix, ?string $suffix = null): array
{
if (is_null($suffix)) {
$suffix = $prefix;
Expand Down