libindex: fix fetcher leak #1628
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdonnay
force-pushed
the
bug/fetcher-leak
branch
2 times, most recently
from
e8545e9 to
0950161
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Since this code was added, the `math/rand/v2` package has landed and does the same thing (use the runtime's fast random numbers), but in a supported way. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
This also ends up restructuring things to work with normal `*os.File` instead of the `tempFile` type. Signed-off-by: Hank Donnay <hdonnay@redhat.com>
hdonnay
force-pushed
the
bug/fetcher-leak
branch
from
0950161 to
a5e53ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is should fix a file descriptor (and file) leak when there's an error return while writing the file. This leak would result in the file descriptor hanging around until a GC cycle and the backing file not being deleted when not using
O_TMPFILE.Depends on: #1547