-
-
Notifications
You must be signed in to change notification settings - Fork 42.6k
DD support for RP2040 bootloader options #25660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
I feel like bootloader.rp2040.(options) would make more sense here, and be a bit more future proof. But implementing might be problematic |
I agree that might be more future proof, and Will see what I can do, along with migrating existing keyboards and migration support in |
Bootloader is already used, and isn't an object so can't be implemented that way. |
0e92b2a
to
300326e
Compare
Yup, I figured as much. :/
|
Description
Adds mappings to configure:
RP2040_BOOTLOADER_DOUBLE_TAP_RESET
:rp2040_bootloader.double_tap_reset
RP2040_BOOTLOADER_DOUBLE_TAP_RESET_TIMEOUT
:rp2040_bootloader.double_tap_reset_timeout
RP2040_BOOTLOADER_DOUBLE_TAP_RESET_LED
:rp2040_bootloader.double_tap_reset_led
Switches to using
UINT32_C()
macro to type the value when it is used, rather than where it is defined.Types of Changes
Checklist