Skip to content

Conversation

waffle87
Copy link
Member

Description

Adds mappings to configure:

  • RP2040_BOOTLOADER_DOUBLE_TAP_RESET: rp2040_bootloader.double_tap_reset
  • RP2040_BOOTLOADER_DOUBLE_TAP_RESET_TIMEOUT: rp2040_bootloader.double_tap_reset_timeout
  • RP2040_BOOTLOADER_DOUBLE_TAP_RESET_LED: rp2040_bootloader.double_tap_reset_led

Switches to using UINT32_C() macro to type the value when it is used, rather than where it is defined.

Types of Changes

  • Core
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core documentation dd Data Driven Changes labels Sep 16, 2025
@waffle87 waffle87 marked this pull request as draft September 16, 2025 20:03
@drashna
Copy link
Member

drashna commented Sep 16, 2025

I feel like bootloader.rp2040.(options) would make more sense here, and be a bit more future proof. But implementing might be problematic

@waffle87
Copy link
Member Author

I agree that might be more future proof, and qmk_lufa_bootloader could potentially be migrated under bootloader as well.

Will see what I can do, along with migrating existing keyboards and migration support in info.py.

@zvecr
Copy link
Member

zvecr commented Sep 16, 2025

Bootloader is already used, and isn't an object so can't be implemented that way.

@github-actions github-actions bot added keyboard python cli qmk cli command labels Sep 17, 2025
@waffle87 waffle87 force-pushed the dd/rp2040_config_opts branch from 0e92b2a to 300326e Compare September 17, 2025 04:23
@drashna
Copy link
Member

drashna commented Sep 17, 2025

Bootloader is already used, and isn't an object so can't be implemented that way.

Yup, I figured as much. :/

bootloader_settings might work though?

@waffle87 waffle87 marked this pull request as ready for review September 22, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants